[
https://issues.apache.org/jira/browse/YARN-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515162#comment-16515162
]
Szilard Nemeth commented on YARN-6995:
--------------------------------------
Hey [~templedf]!
I have 2 comments for this patch:
1. Referring back to Yufei's previous comment, the order of the parameters is
mistakenly swapped in the exception message: {{String.format(MESSAGE, resource,
type) should be String.format(MESSAGE, type, resource).}}
2. Stack trace of the exception is not printed in the exception message "...
The stack trace for this exception\nAfter encountering..."
Have you intended to put {{ExceptionUtils.getStackTrace()}} before the line
break?
> Improve use of ResourceNotFoundException in resource types code
> ---------------------------------------------------------------
>
> Key: YARN-6995
> URL: https://issues.apache.org/jira/browse/YARN-6995
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Minor
> Attachments: YARN-6995.005.patch, YARN-6995.YARN-3926.001.patch,
> YARN-6995.YARN-3926.002.patch, YARN-6995.YARN-3926.003.patch,
> YARN-6995.YARN-3926.004.patch
>
>
> Now that all the YarnExceptions have been replaced with
> ResourceNotFoundExceptions, we should make the ResourceNotFoundExceptions as
> useful as possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
