[
https://issues.apache.org/jira/browse/YARN-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517344#comment-16517344
]
Miklos Szegedi commented on YARN-7449:
--------------------------------------
Thank you for the patch [~snemeth]. I still see references to the
implementation class in TestYarnClient:
{code:java}
1164 YarnClientImpl impl = (YarnClientImpl) client;
1165 YarnClientImpl spyClient = spy(impl);{code}
Also, could you address the whitespace issue?
> Split up class TestYarnClient to TestYarnClient and TestYarnClientImpl
> ----------------------------------------------------------------------
>
> Key: YARN-7449
> URL: https://issues.apache.org/jira/browse/YARN-7449
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: client, yarn
> Reporter: Yufei Gu
> Assignee: Szilard Nemeth
> Priority: Minor
> Labels: newbie, newbie++
> Attachments: YARN-7449-001.patch
>
>
> {{TestYarnClient}} tests both {{YarnClient}} and {{YarnClientImpl}}. We
> should test {{YarnClient}} without thinking of its implementation. That's the
> whole point of {{YarnClient}}. There are bunch of refactors we could do. The
> first thing is to Split up class {{TestYarnClient}} to {{TestYarnClient}} and
> {{TestYarnClientImpl}}. Let {{TestYarnClient}} only tests {{YarnClient}}. All
> implementation related stuff go to {{TestYarnClientImpl}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
