[
https://issues.apache.org/jira/browse/YARN-6794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517513#comment-16517513
]
Haibo Chen commented on YARN-6794:
----------------------------------
Thanks [~szegedim] for the review!.
{quote}I think this should refer to allocatedResourceOpportunistic
{quote}
Good catch. I have corrected this.
{quote}It might be safer to do a clone here and return a read only copy.
{quote}
I have addressed this in the new patch.
{quote}Is this really true? I could imagine that we try but cannot assign a
reserved resource but we do not even try the opportunistic queue in that case.
{quote}
I have made it more explicitly by saying no more resources are available for
promotion. The purpose here is that we satisfy resource requests that are
eligible for guaranteed resources in FIFO order. If a reservation is made
before an opportunistic container is allocated. We should allow opportunistic
container promotion only after the reservation is assigned successfully. The
FIFO order also holds in cases where opportunistic containers are allocated
before a reservation is made.
For the synchronization related issues, I have made quite some changes that
move the code in order to improve the locking.
> Fair Scheduler to explicitly promote OPPORTUNISITIC containers locally at the
> node where they're running
> --------------------------------------------------------------------------------------------------------
>
> Key: YARN-6794
> URL: https://issues.apache.org/jira/browse/YARN-6794
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, scheduler
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Priority: Major
> Attachments: YARN-6794-YARN-1011.00.patch,
> YARN-6794-YARN-1011.prelim.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
