[ 
https://issues.apache.org/jira/browse/YARN-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhankun Tang updated YARN-8456:
-------------------------------
    Description: 
*Issue:*
 When the user doesn't configure 
"yarn.nodemanager.resource-plugins.fpga.path-to-discovery-executables" in 
yarn-site.xml and have "ALTERAOCLSDKROOT" environment variable set, the FPGA 
discoverer cannot find the correct executable path (with IntelFPGAOpenclPlugin).

*Reason:*

In IntelFPGAOpenclPlugin,  the current code builds a wrong path string after 
getting the environment variable value. It should append "/bin/<executable 
name>" otherwise it would fail the FPGA resource discovery.

 

*Solution:*

Fix the path construction code in IntelFPGAOpenclPlugin.

 

*MISC:*

The patch also corrects some minor issues:
 # Change _"yarn-io/_gpu_"_ and _"yarn-io/_fpga_"_ to _"yarn.io/gpu"_, 
_"yarn.io/fpga"_ in documents
 # Use _"auto"_ as the default value for 
"yarn.nodemanager.resource-plugins.fpga.allowed-fpga-devices". The original 
"0,1" won't cause any problem but use "auto" is better

 

  was:
*Issue:*
When the user doesn't configure 
"yarn.nodemanager.resource-plugins.fpga.path-to-discovery-executables" in 
yarn-site.xml and have "ALTERAOCLSDKROOT" environment variable set, the FPGA 
discoverer cannot find the correct executable path (with IntelFPGAOpenclPlugin).

*Reason:*

In IntelFPGAOpenclPlugin,  the current code builds a wrong path string after 
getting the environment variable value. It should append "/bin/<executable 
name>" otherwise it would fail the FPGA resource discovery.

 

*Solution:*

Fix the path construction code in IntelFPGAOpenclPlugin.

 

*MISC:*

The patch also corrects some minor errors:
 # Change _"yarn-io/_gpu_"_ and _"yarn-io/_fpga_"_ to _"yarn.io/gpu"_, 
_"yarn.io/fpga"_ in documents
 # Use _"auto"_ as the default value for 
"yarn.nodemanager.resource-plugins.fpga.allowed-fpga-devices". The original 
"0,1" won't cause any problem but use "auto" is better

 


> Fix a bug when user leave FPGA discover executable path configuration default 
> but set OpenCL SDK path environment variable
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8456
>                 URL: https://issues.apache.org/jira/browse/YARN-8456
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Zhankun Tang
>            Assignee: Zhankun Tang
>            Priority: Major
>         Attachments: YARN-8456-trunk.001.path
>
>
> *Issue:*
>  When the user doesn't configure 
> "yarn.nodemanager.resource-plugins.fpga.path-to-discovery-executables" in 
> yarn-site.xml and have "ALTERAOCLSDKROOT" environment variable set, the FPGA 
> discoverer cannot find the correct executable path (with 
> IntelFPGAOpenclPlugin).
> *Reason:*
> In IntelFPGAOpenclPlugin,  the current code builds a wrong path string after 
> getting the environment variable value. It should append "/bin/<executable 
> name>" otherwise it would fail the FPGA resource discovery.
>  
> *Solution:*
> Fix the path construction code in IntelFPGAOpenclPlugin.
>  
> *MISC:*
> The patch also corrects some minor issues:
>  # Change _"yarn-io/_gpu_"_ and _"yarn-io/_fpga_"_ to _"yarn.io/gpu"_, 
> _"yarn.io/fpga"_ in documents
>  # Use _"auto"_ as the default value for 
> "yarn.nodemanager.resource-plugins.fpga.allowed-fpga-devices". The original 
> "0,1" won't cause any problem but use "auto" is better
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to