[
https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538215#comment-16538215
]
Masatake Iwasaki commented on YARN-5748:
----------------------------------------
[~hexiaoqiao], I looked into the code again. Since
"dfs.client.retry.policy.enabled" is used only in non-HA setup,
testFSRMStateStoreNNFailover added by the 002 patch is useless. It always
succeeds in current branch-2 regardless to retry policy settings. I think
FSRMStateStore has no problem caused by overwriting retry policy spec. If you
have setup to reproduce the issue, it will be help to rewrite the unit test.
> Backport YARN-5718 to branch-2
> ------------------------------
>
> Key: YARN-5748
> URL: https://issues.apache.org/jira/browse/YARN-5748
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Junping Du
> Assignee: Masatake Iwasaki
> Priority: Major
> Attachments: YARN-5748-branch-2.001.patch,
> YARN-5748-branch-2.002.patch
>
>
> In YARN-5718, we have identify several unnecessary config to over-write HDFS
> client behavior in several components of YARN (FSRMStore, TimelineClient,
> NodeLabelStore, etc.) which cause job failure in some cases (NN HA, etc.) -
> that's definitely belongs to bug. In YARN-5718, we proposed to remove the
> config as it shouldn't be supposed to work, which get committed to trunk
> already as alpha stage has more flexibility for incompatible changes. In
> branch-2, we want to play a bit more safe and get more discussion.
> Obviously, there are several options here:
> 1. Don't fix anything, let bug exist
> 2. Fix the bug, but keep the configuration, or mark it deprecated and add
> some explanation to say this configuration is not supposed to work any more.
> 3. Exactly like YARN-5718, fix the bug and remove the unnecessary
> configuration.
> This ticket is filed for more discussion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
