[
https://issues.apache.org/jira/browse/YARN-8501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538770#comment-16538770
]
Szilard Nemeth commented on YARN-8501:
--------------------------------------
Hi [~Zian Chen]!
As my intellij marks this method with a warning ("Method is too complex to
analyze by data flow algorithm") I was thinking about these:
1. Eliminate the boolean flags
2. Separate validation and throwing exceptions from the rest of the code.
3. Use a builder that creates a {{GetApplicationsRequest}} from the provider
query parameters.
4. Add some testcases in order to verify I don't break anything.
Do you have anything to add to this list?
Thanks!
> Reduce complexity of RMWebServices' getApps method
> --------------------------------------------------
>
> Key: YARN-8501
> URL: https://issues.apache.org/jira/browse/YARN-8501
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: restapi
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
