[
https://issues.apache.org/jira/browse/YARN-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540879#comment-16540879
]
Wangda Tan commented on YARN-7974:
----------------------------------
[[email protected]], [~jhung],
Thanks for updating the patch, in general the patch looks good.
Several minor comments:
1)
{code}
public abstract void updateTrackingUrl(String trackingUrl);
{code}
Should have a default (maybe empty) implementation. Given AMRMClient/Async are
all public/stable APIs, we don't want build break if any app extend from these
classes.
2) The updateTrackingUrl should be marked as public/unstable.
3) Should we explicitly compare content of the new tracking url with old
tracking url? Now we only check != null which may not be enough.
{code}
1824 // Update tracking url if changed and save it to state store
1825 String newTrackingUrl = statusUpdateEvent.getTrackingUrl();
1826 if (newTrackingUrl != null) {
{code}
> Allow updating application tracking url after registration
> ----------------------------------------------------------
>
> Key: YARN-7974
> URL: https://issues.apache.org/jira/browse/YARN-7974
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Jonathan Hung
> Assignee: Jonathan Hung
> Priority: Major
> Attachments: YARN-7974.001.patch, YARN-7974.002.patch,
> YARN-7974.003.patch, YARN-7974.004.patch, YARN-7974.005.patch
>
>
> Normally an application's tracking url is set on AM registration. We have a
> use case for updating the tracking url after registration (e.g. the UI is
> hosted on one of the containers).
> Approach is for AM to update tracking url on heartbeat to RM, and add related
> API in AMRMClient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
