Manikandan R commented on YARN-4175:

I tried to use this patch to see if i can add more test cases for YARN-5590 
with additional support from YARN-7242. I did the following to make this patch 
 # As [~asuresh] mentioned earlier, modified this patch to make use of 
UpdateContainer API's to update containers. Also ensured variables reflect the 
same in the code. However, retained the same shell arguments.
 2. Had come to know that YARN-7242 doesn't take care of resource types units 
from shell arguments. It expects value of type long only and it works based on 
that. Made changes to pass resource types with units and the same would be 
considered for further process. But, it converts the value to "Mi" as of now. 
Ideally, it has to be converted based on server side RM config (Something 
similar to YARN-7159) . For example, If resource type 'resource1' unit is 'Gi' 
configured at RM config and clients are passing values in different units, it 
has to be converted to 'Gi' not to 'Mi'. Thoughts? I can raise a separate JIRA 
to handle this separately based on comments.
 3. As intent is to add more test cases for YARN-5590, did the same to ensure 
containers can be updated using distributed shell both in junits and local 
pseudo set up. I can separate out the patch specific to YARN-5590 changes if 

[~leftnoteasy] [~sunilg] [~asuresh] Please share your views.

> Example of use YARN-1197
> ------------------------
>                 Key: YARN-4175
>                 URL: https://issues.apache.org/jira/browse/YARN-4175
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, nodemanager, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: MENG DING
>            Priority: Major
>         Attachments: YARN-4175.1.patch, YARN-4175.2.patch
> Like YARN-2609, we need a example program to demonstrate how to use YARN-1197 
> from end-to-end.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to