[ 
https://issues.apache.org/jira/browse/YARN-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545711#comment-16545711
 ] 

Gour Saha commented on YARN-8301:
---------------------------------

Thanks [~csingh] for the doc patch. Overall looks good. Few comments -
1.
Change {{path_to_service_def_file}} to {{path_to_new_service_def_file}}

2.

Can you add a sample response of a {{status}} output for the version 1.0.0 of 
the sleeper service and paste it just above the "Initiate Upgrade" section? 
This will put a lot of subsequent references in context, like your service is 
named "my-sleeper" and what sleeper-0 and sleeper-1 are when you refer them in 
"Upgrade Instance" section.

3.

Can you add an "Upgrade Component" example right after "Upgrade Instance"?

4.

In the "Finalize Upgrade" section can you change it to -
{code:java}
User must finalize the upgrade using the below command (since autoFinalize was 
not specified during initiate):{code}

> Yarn Service Upgrade: Add documentation
> ---------------------------------------
>
>                 Key: YARN-8301
>                 URL: https://issues.apache.org/jira/browse/YARN-8301
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>            Priority: Major
>         Attachments: YARN-8301.001.patch
>
>
> Add documentation for yarn service upgrade.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to