[
https://issues.apache.org/jira/browse/YARN-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546962#comment-16546962
]
Szilard Nemeth commented on YARN-7300:
--------------------------------------
Hi [~haibochen]!
Thanks for your review comments.
1. I cannot use YarnRuntimeException as LocalDirAllocator is part of
hadoop-common and yarn is not a dependency of this module.
2. Good idea, introduced a new constructor that has the disk validator as a
dependency. LocalDirsHandlerService is the only user of this new constructor as
it can read the disk validator config (YarnConfiguration.DISK_VALIDATOR) and
instantiate an appropriate validator. The rest of the callers of the existing
constructor remained the same.
3. Fair enough, it's even better to refer to the field.
Please check my new patch!
Thanks!
> DiskValidator is not used in LocalDirAllocator
> ----------------------------------------------
>
> Key: YARN-7300
> URL: https://issues.apache.org/jira/browse/YARN-7300
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Haibo Chen
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-7300.001.patch, YARN-7300.002.patch
>
>
> HADOOP-13254 introduced a pluggable disk validator to replace
> DiskChecker.checkDir(). However, LocalDirAllocator still references the old
> DiskChecker.checkDir(). It'd be nice to
> use the plugin uniformly so that user configurations take effect in all
> places.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
