[
https://issues.apache.org/jira/browse/YARN-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549852#comment-16549852
]
Eric Badger commented on YARN-8380:
-----------------------------------
{noformat}
+ mount_type = get_mount_type(values[i]);
+ if (mount_type == NULL) {
+ fprintf(ERRORFILE, "Invalid docker mount '%s'\n", values[i]);
+ ret = INVALID_DOCKER_MOUNT;
goto free_and_exit;
{noformat}
Am I reading this correctly that if you don't set a mode for the bind mount
that it will not be allowed? E.g. {{-v /tmp:/tmp}} would not be allowed by
this, correct? If so, I don't think that's desirable.
{noformat}
char **permitted_rw_mounts =
get_configuration_values_delimiter("docker.allowed.rw-mounts",
CONTAINER_EXECUTOR_CFG_DOCKER_SECTION, conf, ",");
{noformat}
If we don't necessarily need to get {{permitted_rw_mounts}} for all calls
anymore, we should defer the work of getting all the values until we need to.
> Support shared mounts in docker runtime
> ---------------------------------------
>
> Key: YARN-8380
> URL: https://issues.apache.org/jira/browse/YARN-8380
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Priority: Major
> Attachments: YARN-8380.1.patch, YARN-8380.2.patch
>
>
> The docker run command supports the mount type shared, but currently we are
> only supporting ro and rw mount types in the docker runtime.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
