[
https://issues.apache.org/jira/browse/YARN-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553244#comment-16553244
]
Suma Shivaprasad edited comment on YARN-8418 at 7/23/18 6:36 PM:
-----------------------------------------------------------------
[~bibinchundatt] Thanks for the patch. Had a couple of questions on the patch
The following lines have been deleted in the new patch. Wouldnt this cause
leaks in case of other Exception cases (not Invalid token cases)?
{noformat}
253 appLogAggregators.remove(appId);
254 closeFileSystems(userUgi);
{noformat}
and I see that the exception is being thrown later i.e after the log
aggregation wrapper has been scheduled?
{noformat}
285 if (appDirException != null) {
286 throw appDirException;
287 }
{noformat}
This would also cause issues in exception cases, when the scheduled aggregator
runs?
was (Author: suma.shivaprasad):
[~bibinchundatt] Thanks for the patch. Had a couple of questions on the patch
The following lines have been deleted in the new patch. Wouldnt this cause
leaks in case of other Exception cases (not Invalid token cases)?
{noformat}
253 appLogAggregators.remove(appId);
254 closeFileSystems(userUgi);
{noformat}
and I see that the exception is being thrown later i.e after the log
aggregation wrapper has been scheduled?
{noformat}
285 if (appDirException != null) {
286 throw appDirException;
287 }
This would also cause issues in exception cases, when the scheduled aggregator
runs?
{noformat}
> App local logs could leaked if log aggregation fails to initialize for the app
> ------------------------------------------------------------------------------
>
> Key: YARN-8418
> URL: https://issues.apache.org/jira/browse/YARN-8418
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Critical
> Attachments: YARN-8418.001.patch, YARN-8418.002.patch,
> YARN-8418.003.patch, YARN-8418.004.patch, YARN-8418.005.patch
>
>
> If log aggregation fails init createApp directory container logs could get
> leaked in NM directory
> For log running application restart of NM after token renewal this case is
> possible/ Application submission with invalid delegation token
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
