[
https://issues.apache.org/jira/browse/YARN-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554744#comment-16554744
]
Hudson commented on YARN-7133:
------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14629 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14629/])
YARN-7133. Clean up lock-try order in fair scheduler. (Szilard Nemeth
(haibochen: rev ea2c6c8c9a55813a19b3dbd0d29747d6a7739030)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
> Clean up lock-try order in fair scheduler
> -----------------------------------------
>
> Key: YARN-7133
> URL: https://issues.apache.org/jira/browse/YARN-7133
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 3.0.0-alpha4
> Reporter: Daniel Templeton
> Assignee: Szilard Nemeth
> Priority: Major
> Labels: newbie
> Fix For: 3.2.0
>
> Attachments: YARN-7133.001.patch
>
>
> There are many places that follow the pattern:{code}try {
> lock.lock();
> ...
> } finally {
> lock.unlock();
> }{code}
> There are a couple of reasons that's a bad idea. The correct pattern
> is:{code}lock.lock();
> try {
> ...
> } finally {
> lock.unlock();
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
