[
https://issues.apache.org/jira/browse/YARN-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559023#comment-16559023
]
Chandni Singh commented on YARN-8584:
-------------------------------------
Looks good.
We can also change the log statements to utilize slf4j instead of concatenating
strings.
For example
{code:java}
LOG.warn("rollingMonitorInterval should be more than or equal to " +
MIN_LOG_ROLLING_INTERVAL + " seconds. Using " + MIN_LOG_ROLLING_INTERVAL + "
seconds instead.");{code}
to
{code:java}
LOG.warn("rollingMonitorInterval should be more than or equal to {} seconds.
Using {} seconds instead.", MIN_LOG_ROLLING_INTERVAL,
MIN_LOG_ROLLING_INTERVAL);{code}
> Several typos in Log Aggregation related classes
> ------------------------------------------------
>
> Key: YARN-8584
> URL: https://issues.apache.org/jira/browse/YARN-8584
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-8584.001.patch
>
>
> There are typos in comments, log messages, method names, field names, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
