[
https://issues.apache.org/jira/browse/YARN-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771978#comment-13771978
]
Jonathan Eagles commented on YARN-819:
--------------------------------------
Thanks for the patch, Rob. Couple of minor things to address.
* TestResourceTrackerService#testNodeRegistrationVersionLessThanRM fails on
branch-2. It looks like the tests pick up the version info from the current
build that make the tests pass/fail depending on version in branch.
* There seems to be a discrepancy between the design in the JIRA description
and the implementation regarding checks and actions to take. Can you comment?
* Remove the extra space after the equals in NodeStatusUpdaterImpl
{code:java}this.nodeManagerVersionId = YarnVersionInfo.getVersion();{code}
* Refer to to rm version as rmVersion in message string for consistency in
NodeStatusUpdaterImpl
{code:java}
if (VersionUtil.compareVersions(rmVersion,minimumResourceManagerVersion)
< 0) {
String message = "The Resource Manager's version ("
+ regNMResponse.getRMVersion() +") is less than the minimum "
+ "allowed version " + minimumResourceManagerVersion;
{code}
* Extra class definition for YarnVersion infor in TestNodeStatusUpdater
{code:java}
private static class YarnVersionInfo {
public static String returnVersion = "3.0.0";
public static String getVersion() {
return returnVersion;
}
}
{code}
> ResourceManager and NodeManager should check for a minimum allowed version
> --------------------------------------------------------------------------
>
> Key: YARN-819
> URL: https://issues.apache.org/jira/browse/YARN-819
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Affects Versions: 2.0.4-alpha
> Reporter: Robert Parker
> Assignee: Robert Parker
> Attachments: YARN-819-1.patch, YARN-819-2.patch
>
>
> Our use case is during upgrade on a large cluster several NodeManagers may
> not restart with the new version. Once the RM comes back up the NodeManager
> will re-register without issue to the RM.
> The NM should report the version the RM. The RM should have a configuration
> to disallow the check (default), equal to the RM (to prevent config change
> for each release), equal to or greater than RM (to allow NM upgrades), and
> finally an explicit version or version range.
> The RM should also have an configuration on how to treat the mismatch:
> REJECT, or REBOOT the NM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
