[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561665#comment-16561665
]
Weiwei Yang commented on YARN-7494:
-----------------------------------
Hello [~sunilg]
Thanks for the updates, it looks almost good to me. Just few minor comments
CapacitySchedulerConfiguration.java
* line 2144: this line can be removed
* line 2212: can we rename "timeout" to something like "policySortingInterval"?
MultiNodeSortingManager
* line 58: the logging, while starting RM, I got "Initializing
MultiNodeSortingManager=MultiNodeSortingManager", this should be changed to
"LOG.info("Initializing " + getName());", same as line 58
ResourceUsageBasedMultiNodeLookupPolicy - DefaultMultiNodeLookupPolicy
* It seems this 2 policies are same, can we remove one for simplicity ?
MultiNodeSorter
* line 72: can we print the sorting interval here too?
Thanks
> Add muti node lookup support for better placement
> -------------------------------------------------
>
> Key: YARN-7494
> URL: https://issues.apache.org/jira/browse/YARN-7494
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Sunil Govindan
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-7494.001.patch, YARN-7494.002.patch,
> YARN-7494.003.patch, YARN-7494.004.patch, YARN-7494.005.patch,
> YARN-7494.006.patch, YARN-7494.007.patch, YARN-7494.008.patch,
> YARN-7494.009.patch, YARN-7494.010.patch, YARN-7494.11.patch,
> YARN-7494.v0.patch, YARN-7494.v1.patch, multi-node-designProposal.png
>
>
> Instead of single node, for effectiveness we can consider a multi node lookup
> based on partition to start with.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
