[ 
https://issues.apache.org/jira/browse/YARN-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562621#comment-16562621
 ] 

Gour Saha commented on YARN-8392:
---------------------------------

[~billie.rinaldi] thank you for the patch. This symmetric scenario will be a 
good one to open up for services. The patch looks good to me. +1 for it.

Just one comment on the error message -
{code}
  String ERROR_PLACEMENT_POLICY_TAG_INVALID = "Invalid target tag %s "
      + "specified in placement policy of component %s. Component %s must "
      + "also appear in placement policy of component %s with the same "
      + "constraint type.";
{code}
Since we are checking for scope in addition to constraint type, should we 
explicitly mention that in the error message too?

> Allow multiple tags for anti-affinity placement policy in service 
> specification
> -------------------------------------------------------------------------------
>
>                 Key: YARN-8392
>                 URL: https://issues.apache.org/jira/browse/YARN-8392
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>            Priority: Critical
>         Attachments: YARN-8392.1.patch, YARN-8392.2.patch, YARN-8392.3.patch
>
>
> Currently the service client code is restricting a component's target tags to 
> include only a single tag, the component name. I have a use case for two 
> components having anti-affinity with themselves and with each other. The YARN 
> placement policies support this, but the service framework isn't allowing it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to