[
https://issues.apache.org/jira/browse/YARN-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773348#comment-13773348
]
Vinod Kumar Vavilapalli commented on YARN-1204:
-----------------------------------------------
Looks fine overall. Comments on the patch:
- Split the MR changes into a MR Jira. The patch can also be separated.
- Don't understand the diff between getRMWebAppHostAndPort() and
getRMWebAppURL() looking at their names, fix'em.
- Why isn't NM's web-server using the util methods currently in
YarnConfiguration?
- Similarly in RM.
- Similar to the get API, we can have a util method for setting http/https
address and use that in ResourceManager.java and MiniYarnCluster.
- Should add setter utils for NM http(s) URLs and use them in MiniYarnCluster.
- Add setter and getter utils for JHS URLs and use in MiniMRYarnCluster.
- In ResourceManager.java, it is already calling
YarnConfiguration.getRMWebAppHostAndPort() which is bound to return host and
port. So the following checks looking for ":" are redundant.
> Need to add https port related property in Yarn
> -----------------------------------------------
>
> Key: YARN-1204
> URL: https://issues.apache.org/jira/browse/YARN-1204
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Yesha Vora
> Assignee: Omkar Vinit Joshi
> Attachments: YARN-1204.20131018.1.patch
>
>
> There is no yarn property available to configure https port for Resource
> manager, nodemanager and history server. Currently, Yarn services uses the
> port defined for http [defined by
> 'mapreduce.jobhistory.webapp.address','yarn.nodemanager.webapp.address',
> 'yarn.resourcemanager.webapp.address'] for running services on https protocol.
> Yarn should have list of property to assign https port for RM, NM and JHS.
> It can be like below.
> yarn.nodemanager.webapp.https.address
> yarn.resourcemanager.webapp.https.address
> mapreduce.jobhistory.webapp.https.address
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
