[ 
https://issues.apache.org/jira/browse/YARN-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570604#comment-16570604
 ] 

Subru Krishnan commented on YARN-8626:
--------------------------------------

Thanks [~elgoiri] for the patch. I looked at it, please find my comments below:
 * We generally use _home_ and not _local_. In this case I suggest replacing 
_local_ with either _home_ or _reflexive_?
 * If possible, can you remove the empty *notifyOfResponse* impls from the 
stateless AMRMProxyPolicies as those are now redundant.
 * In the {{LocalAMRMProxyPolicy}}, add a check to validate the _home SC_ is 
indeed active (and corresponding test).
 * The *FederationPolicyInitializationContext* will not have the _home SC_ set 
in {{LocalRouterPolicy}} as it's the responsibility of the router to do so 
(chicken or egg situation :)). If you have capacity reserved, then the ideal 
approach would be to query the _StateStore_ to figure out which SC has capacity 
and select that as the _home SC_. If you don't have capacity reserved, then you 
should use *UniformRandomRouterPolicy* directly.
 * Add a test for {{LocalRouterPolicy}} if it's still required based on above 
comment.

> Create LocalPolicyManager that sends all the requests to the home subcluster
> ----------------------------------------------------------------------------
>
>                 Key: YARN-8626
>                 URL: https://issues.apache.org/jira/browse/YARN-8626
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Íñigo Goiri
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: YARN-8626.000.patch, YARN-8626.001.patch, 
> YARN-8626.002.patch, YARN-8626.003.patch, YARN-8626.004.patch, 
> YARN-8626.005.patch
>
>
> To have the same behavior as a regular non-federated deployment, one should 
> be able to submit jobs to the local RM and get the job constrained to that 
> subcluster.
> This JIRA creates an AMRMProxyPolicy that sends resources to the home 
> subcluster and mimics the behavior of a non-federated cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to