[ 
https://issues.apache.org/jira/browse/YARN-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573712#comment-16573712
 ] 

Chandni Singh edited comment on YARN-8298 at 8/8/18 7:01 PM:
-------------------------------------------------------------

[~eyang] Thanks for working on this.
Why does {{ServiceState.UPGRADING_AUTO_FINALIZE}} trigger express upgrade?
Please refer to the design document in YARN-7512. 
{{ServiceState.UPGRADING_AUTO_FINALIZE}} is to trigger automatic finalization 
of service upgrade. It isn't for express upgrade of the service. 

It will be useful to not club ServiceState.UPGRADING_AUTO_FINALIZE with express 
upgrade. They have different meanings. A user may want auto-finalization 
without  express upgrade. There isn't any complexity in supporting this 
technically as will
 
If you require a flag to trigger express upgrade, why not add a query param to 
update service endpoint?
If the ServiceState = {{ServiceState.UPGRADING}} or 
{{ServiceState.UPGRADING_AUTO_FINALIZE}} and 
the query param expressUpgrade = true, then perform express upgrade.



was (Author: csingh):
[~eyang] 
Why does {{ServiceState.UPGRADING_AUTO_FINALIZE}} trigger express upgrade?
Please refer to the design document in YARN-7512. 
{{ServiceState.UPGRADING_AUTO_FINALIZE}} is to trigger automatic finalization 
of service upgrade. It isn't for express upgrade of the service. 

It will be useful to not club ServiceState.UPGRADING_AUTO_FINALIZE with express 
upgrade. They have different meanings. A user may want auto-finalization 
without  express upgrade. There isn't any complexity in supporting this 
technically as will
 
If you require a flag to trigger express upgrade, why not add a query param to 
update service endpoint?
If the ServiceState = {{ServiceState.UPGRADING}} or 
{{ServiceState.UPGRADING_AUTO_FINALIZE}} and 
the query param expressUpgrade = true, then perform express upgrade.


> Yarn Service Upgrade: Support express upgrade of a service
> ----------------------------------------------------------
>
>                 Key: YARN-8298
>                 URL: https://issues.apache.org/jira/browse/YARN-8298
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 3.1.1
>            Reporter: Chandni Singh
>            Assignee: Eric Yang
>            Priority: Major
>         Attachments: YARN-8298.001.patch, YARN-8298.002.patch
>
>
> Currently service upgrade involves 2 steps
>  * initiate upgrade by providing new spec
>  * trigger upgrade of each instance/component
>  
> We need to add the ability to upgrade a component in shot which accepts the 
> spec of the component. However there are couple of limitations when upgrading 
> in this way:
>  # Aborting the upgrade will not be supported
>  # Upgrade finalization will be done automatically.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to