[
https://issues.apache.org/jira/browse/YARN-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578945#comment-16578945
]
Yufei Gu commented on YARN-8632:
--------------------------------
Thanks for the patch. Some comments:
# It is not a good practice to catch runtime exception. Normally we should let
the program exit if a runtime exception happens. Create a new exception if you
think it is necessary and throw and catch it explicitly.
# Use {{LOG.info("message", e)}} instead of {{e.printStackTrace();}}
# {{(SchedulerWrapper)scheduler;}} needs a space before "scheduler"
# Create a unitest if possible.
> No data in file realtimetrack.json after running SchedulerLoadSimulator
> -----------------------------------------------------------------------
>
> Key: YARN-8632
> URL: https://issues.apache.org/jira/browse/YARN-8632
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler-load-simulator
> Reporter: Xianghao Lu
> Assignee: Xianghao Lu
> Priority: Major
> Attachments: YARN-8632-branch-2.7.2.001.patch, YARN-8632.001.patch
>
>
> Recently, I have beenning using
> [SchedulerLoadSimulator|https://hadoop.apache.org/docs/r2.7.2/hadoop-sls/SchedulerLoadSimulator.html]
> to validate the impact of changes on my FairScheduler. I encountered some
> problems.
> Firstly, I fix a npe bug with the patch in
> https://issues.apache.org/jira/browse/YARN-4302
> Secondly, Everything seems to be ok, but I just get "[]" in file
> realtimetrack.json. Finally, I find the MetricsLogRunnable thread will exit
> because of npe,
> the reason is "wrapper.getQueueSet()" is still null when executing "String
> metrics = web.generateRealTimeTrackingMetrics();"
> So, we should put "String metrics = web.generateRealTimeTrackingMetrics();"
> in try section to avoid MetricsLogRunnable thread exit with unexpected
> exception.
> My hadoop version is 2.7.2, it seems that hadoop trunk branch also has the
> second problem and I have made a patch to solve it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
