[
https://issues.apache.org/jira/browse/YARN-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579199#comment-16579199
]
Sunil Govindan commented on YARN-8657:
--------------------------------------
Hi [~leftnoteasy]
Thanks for the patch. Some doubts on this.
{{computeUserLimitAndSetHeadroom}} is invoked under readLock in few places and
writeLock under {{updateClusterResource}}. With this patch, this method is now
called under readLock. However other than
{{metrics.setAvailableResourcesToUser(nodePartition, user, headroom);}}, all
other setters are under respective locks. I think this also to be protected as
I have seen some recent issues in metrics in queue metrics. I suspect this is
one reason.
{{computeUserLimitAndSetHeadroom}} has this annotation. I think this need to
revisited ? *@Lock(\{LeafQueue.class})*
> User limit calculation should be read-lock-protected within LeafQueue
> ---------------------------------------------------------------------
>
> Key: YARN-8657
> URL: https://issues.apache.org/jira/browse/YARN-8657
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Reporter: Sumana Sathish
> Assignee: Wangda Tan
> Priority: Critical
> Attachments: YARN-8657.001.patch
>
>
> When async scheduling is enabled, user limit calculation could be wrong:
> It is possible that scheduler calculated a user_limit, but inside
> {{canAssignToUser}} it becomes staled.
> We need to protect user limit calculation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
