[
https://issues.apache.org/jira/browse/YARN-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581598#comment-16581598
]
Eric Yang commented on YARN-8488:
---------------------------------
[~suma.shivaprasad], thank you for the patch. A few minor nitpicks:
# Introduce synchronized boolean getTimelineServiceEnabled method to make this
class thread safe.
#
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/Component.java
changes is unnecessary.
# ComponentInstance.java, near line 265, } else {
# It might be useful to pass in a real diagnostic string to
handleComponentInstanceRelaunch to make sure the down stream classes isn't
failing to due NPE.
The new state works fine.
> YARN service/components/instances should have SUCCEEDED/FAILED states
> ---------------------------------------------------------------------
>
> Key: YARN-8488
> URL: https://issues.apache.org/jira/browse/YARN-8488
> Project: Hadoop YARN
> Issue Type: Task
> Components: yarn-native-services
> Reporter: Wangda Tan
> Assignee: Suma Shivaprasad
> Priority: Major
> Attachments: YARN-8488.1.patch, YARN-8488.2.patch, YARN-8488.3.patch,
> YARN-8488.4.patch, YARN-8488.5.patch
>
>
> Existing YARN service has following states:
> {code}
> public enum ServiceState {
> ACCEPTED, STARTED, STABLE, STOPPED, FAILED, FLEX, UPGRADING,
> UPGRADING_AUTO_FINALIZE;
> }
> {code}
> Ideally we should add "SUCCEEDED" state in order to support long running
> applications like Tensorflow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
