[
https://issues.apache.org/jira/browse/YARN-8509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595610#comment-16595610
]
Eric Payne commented on YARN-8509:
----------------------------------
bq. I'll comment on the updates once I have some progress.
[~Zian Chen], my point was that the latest patch changes the behavior of the
container assign logic, not just the preemption logic. We should be able to
make the needed changes inside of
{{LeafQueue#getTotalPendingResourcesConsideringUserLimit}}, which is only
called by preemption code.
When you make changes that are intended for preemption and you have to make
changes to unit tests that are outside of preemption, that should be a red flag.
> Total pending resource calculation in preemption should use user-limit factor
> instead of minimum-user-limit-percent
> -------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-8509
> URL: https://issues.apache.org/jira/browse/YARN-8509
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Reporter: Zian Chen
> Assignee: Zian Chen
> Priority: Major
> Labels: capacityscheduler
> Attachments: YARN-8509.001.patch, YARN-8509.002.patch,
> YARN-8509.003.patch, YARN-8509.004.patch, YARN-8509.005.patch
>
>
> In LeafQueue#getTotalPendingResourcesConsideringUserLimit, we calculate total
> pending resource based on user-limit percent and user-limit factor which will
> cap pending resource for each user to the minimum of user-limit pending and
> actual pending. This will prevent queue from taking more pending resource to
> achieve queue balance after all queue satisfied with its ideal allocation.
>
> We need to change the logic to let queue pending can go beyond userlimit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
