[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598229#comment-16598229
]
Rohith Sharma K S commented on YARN-8303:
-----------------------------------------
Thanks [~abmodi] for the patch.. Approach looks good to me.. Few comments
# Can we move TimelineEntity converting into XXXXReport into hadoop-yarn-common
utils? Something like
hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/timeline/TimelineEntityConverter.java.
This is helpful while doing YARN-8304 at which generic log servlet required to
fetch log from v1/v2. Probably we might include methods
toXXXXReport(TimelineEntity entity) for both v1 and v2 versions. Good thing is
TimelineReaderClientImpl placed in hadoop-yarn-common package which is useful
for both!
# In class, AHSClient constructor always gives preference for v2 client. YARN
support publishing into both v1 and v2 versions. So, create a v1/v2 client
based on parameters. I think we shouldn't relay on single source of truth when
both versions are available. What I see from production cluster is if HBase
back end is very much unstable then we may not get full report for entities.
> YarnClient should contact TimelineReader for application/attempt/container
> report
> ---------------------------------------------------------------------------------
>
> Key: YARN-8303
> URL: https://issues.apache.org/jira/browse/YARN-8303
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Rohith Sharma K S
> Assignee: Abhishek Modi
> Priority: Critical
> Attachments: YARN-8303.poc.patch
>
>
> YarnClient get app/attempt/container information from RM. If RM doesn't have
> then queried to ahsClient. When ATSv2 is only enabled, yarnClient will result
> empty.
> YarnClient is used by many users which result in empty information for
> app/attempt/container report.
> Proposal is to have adapter from yarn client so that app/attempt/container
> reports can be generated from AHSv2Client which does REST API to
> TimelineReader and get the entity and convert it into app/attempt/container
> report.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
