[
https://issues.apache.org/jira/browse/YARN-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601234#comment-16601234
]
Miklos Szegedi commented on YARN-8717:
--------------------------------------
Thanks, [~yangjiandan] for raising this and the patch and [~cheersyang] for the
review. Yes, this may result in more frequent OOM events. The concern is the
order in this case since you let the kernel decide, which container process to
pick. Have you considered using CGroupElasticMemoryController? In that case
YARN has the control over the priorities of containers.
Just a minor comment:
{code:java}
108 if (yarnMemoryMb != systemMemoryMb) {
109 LOG.info("YARN containers restricted memory to " + yarnMemoryMb + "M");
110 this.cGroupsHandler.updateCGroupParam(MEMORY, "",
111 CGroupsHandler.CGROUP_PARAM_MEMORY_HARD_LIMIT_BYTES,
112 String.valueOf(yarnMemoryMb) + "M");
113 }
{code}
I would probably use a < there, to make sure it does not confuse the edge cases
and also it might be better to log after the action, to help debugging, if it
throws an exception.
> set memory.limit_in_bytes when NodeManager starting
> ---------------------------------------------------
>
> Key: YARN-8717
> URL: https://issues.apache.org/jira/browse/YARN-8717
> Project: Hadoop YARN
> Issue Type: New Feature
> Reporter: Jiandan Yang
> Assignee: Jiandan Yang
> Priority: Major
> Labels: cgroups
> Attachments: YARN-8717.001.patch
>
>
> CGroupsCpuResourceHandlerImpl sets cpu quota at hirarchy of hadoop-yarn to
> restrict total resource of cpu of NM when NM starting;
> CGroupsMemoryResourceHandlerImpl also should set memory.limit_in_bytes at
> hirachy of hadoop-yarn to control memory resource of NM
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
