[
https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602270#comment-16602270
]
Pradeep Ambati commented on YARN-8680:
--------------------------------------
Thanks for the review [~jlowe].
I have addressed all but one issues you pointed out. I didn't address this
comment.
{quote}It would be cleaner to have a LocalResourceTrackerState constructor that
takes the values as arguments and then mark the internal
LocalResourceTrackerState fields as final. Then there is no need to have setter
methods for LocalResourceTrackerState.{quote}
This is a bit complex, as LocalTrackerState is present in
RecoveredLocalizationState and RecoveredUserResources and the way these class
objects are initialized the LocalTrackerState of respective class object is
assigned/initialized later than they are created/intialized. I will look into a
way to do this and if possible put a patch for that.
> YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate
> ---------------------------------------------------------------------
>
> Key: YARN-8680
> URL: https://issues.apache.org/jira/browse/YARN-8680
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Pradeep Ambati
> Assignee: Pradeep Ambati
> Priority: Critical
> Attachments: YARN-8680.00.patch, YARN-8680.01.patch,
> YARN-8680.02.patch
>
>
> Similar to YARN-8242, implement iterable abstraction for
> LocalResourceTrackerState to load completed and in progress resources when
> needed rather than loading them all at a time for a respective state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
