[ 
https://issues.apache.org/jira/browse/YARN-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604773#comment-16604773
 ] 

Bibin A Chundatt commented on YARN-7592:
----------------------------------------

[~jira.shegalov]

Following are my understanding based on discussion in YARN-8434

As per 
[comment|https://issues.apache.org/jira/browse/YARN-8434?focusedCommentId=16539415&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16539415]
 from [~subru]  FederationRMFailoverProxyProvider is intenally set for 
connection retry handling.


IIUC {{RMProxy#createRMProxy}} , federation check is not required. Also 
following code seems to have issue {{RMProxy#newProxyInstance}} 

{code}
  private static <T> T newProxyInstance(final YarnConfiguration conf,
      final Class<T> protocol, RMProxy<T> instance, RetryPolicy retryPolicy)
          throws IOException{
    if (HAUtil.isHAEnabled(conf) || HAUtil.isFederationEnabled(conf)) {
      RMFailoverProxyProvider<T> provider =
          instance.createRMFailoverProxyProvider(conf, protocol);
      return (T) RetryProxy.create(protocol, provider, retryPolicy);
    } else {
      InetSocketAddress rmAddress = instance.getRMAddress(conf, protocol);
      LOG.info("Connecting to ResourceManager at " + rmAddress);
      T proxy = instance.getProxy(conf, protocol, rmAddress);
      return (T) RetryProxy.create(protocol, proxy, retryPolicy);
    }
  }
{code}

Router + 1 RM (non HA) - 2 NM and Federation enabled topology.
{{ConfiguredRMFailoverProxyProvider}}  get intialized as Failover Provider  
ServerProxy and fails to connect to RM. Exception @
{code}
 this.rmServiceIds = rmIds.toArray(new String[rmIds.size()]);
    conf.set(YarnConfiguration.RM_HA_ID, rmServiceIds[currentProxyIndex]);
{code}

cc:/ [~subru]





> yarn.federation.failover.enabled missing in yarn-default.xml
> ------------------------------------------------------------
>
>                 Key: YARN-7592
>                 URL: https://issues.apache.org/jira/browse/YARN-7592
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: federation
>    Affects Versions: 3.0.0-beta1
>            Reporter: Gera Shegalov
>            Priority: Major
>
> yarn.federation.failover.enabled should be documented in yarn-default.xml. I 
> am also not sure why it should be true by default and force the HA retry 
> policy in {{RMProxy#createRMProxy}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to