[
https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612193#comment-16612193
]
Szilard Nemeth commented on YARN-3525:
--------------------------------------
Hi [~zsiegl]!
Thanks for the patch, I like this deprecation approach.
Please use String constants for {{yarn.scheduler.fair.increment-allocation-mb
yarn.scheduler.fair.increment-allocation-vcores}} and
{{yarn.scheduler.fair.increment-allocation-mb
yarn.scheduler.fair.increment-allocation-vcores}} in the test where possible.
Otherwise the patch looks good to me.
> Rename fair scheduler properties increment-allocation-mb and
> increment-allocation-vcores
> ----------------------------------------------------------------------------------------
>
> Key: YARN-3525
> URL: https://issues.apache.org/jira/browse/YARN-3525
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Bibin A Chundatt
> Assignee: Zoltan Siegl
> Priority: Minor
> Attachments: YARN-3525.001.patch
>
>
> Rename below two properties since only used by fair scheduler
> {color:blue}yarn.scheduler.increment-allocation-mb{color} to
> {color:red}yarn.scheduler.fair.increment-allocation-mb{color}
> {color:blue}yarn.scheduler.increment-allocation-vcores{color} to
> {color:red}yarn.scheduler.fair.increment-allocation-vcores{color}
> All other properties only for fair scheduler are using {color:red}
> yarn.scheduler.fair{color} prefix .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
