[
https://issues.apache.org/jira/browse/YARN-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613623#comment-16613623
]
Sunil Govindan commented on YARN-8757:
--------------------------------------
Thanks [~leftnoteasy]
Some comments
1.
{code:java}
113 tensorboardDockerImage = parsedCommandLine.getOptionValue(
114 CliConstants.TENSORBOARD_DOCKER_IMAGE);{code}
In above segment, we have to handle default case also, correct ?
2. In {{updateParametersByParsedCommandline}},
{{setWorkerResource(workerResource)}} is removed, is this intentional?
3.
{code:java}
467 // Add tensorboard to quicklink
468 String tensorboardLink = "http://"; + YarnServiceUtils.getDNSName(
469 parameters.getName(), TaskType.TENSORBOARD.getComponentName(), 0,
470 getUserName(), getDNSDomain(), 6006);{code}
Could we make *http*, *6006* etc from some common config end point or from
default constants.
4. I think we can publish tensorboard link in all cases when user asks for
tensorboard. May not need to check for verbose.
Tests looks good to me. Thank you.
> [Submarine] Add Tensorboard component when --tensorboard is specified
> ---------------------------------------------------------------------
>
> Key: YARN-8757
> URL: https://issues.apache.org/jira/browse/YARN-8757
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Priority: Critical
> Attachments: YARN-8757.001.patch, YARN-8757.002.patch
>
>
> We need to have a Tensorboard component when --tensorboard is specified. And
> we need to set quicklinks to let users view tensorboard.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
