[ 
https://issues.apache.org/jira/browse/YARN-7018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616398#comment-16616398
 ] 

Manikandan R edited comment on YARN-7018 at 9/15/18 5:09 PM:
-------------------------------------------------------------

[~jlowe] [~leftnoteasy] Thanks for your comments.

Addressed the following:

1. Introduced init, stop, addNode, removeNode methods in interface to handle 
the cases described in earlier comment. 

2. Introduced refreshConfigs as described in earlier comment.

3. Kept the plugin interactions into each of the schedulers.

{quote}Back to the prototype patch, I assume NodeHeartBeatPluginImpl is just an 
example and would not be part of the final commit?{quote}

Yes, thats the initial thought. But then, was thinking to mould it as concrete 
implementation at least for one scheduler (for ex, say CS) so that it can act 
as well defined example for future plugin development. Hence asked you to 
suggest potential movable code parts from CS scheduler. Thoughts?

Also, Where shall we keep the plugin? RMActiveService? or Scheduler like 
[~leftnoteasy] suggested earlier? 


was (Author: [email protected]):
[~jlowe] [~leftnoteasy] Thanks for your comments.

Addressed the following:

1. Introduced init, stop, addNode, removeNode methods in interface to handle 
the cases described in earlier comment. 

2. Introduced refreshConfigs as described in earlier comment.

3. Kept the plugin interactions into each of the schedulers.

{quote}Back to the prototype patch, I assume NodeHeartBeatPluginImpl is just an 
example and would not be part of the final commit?\{quote}

Yes, thats the initial thought. But then, was thinking to mould it as concrete 
implementation at least for one scheduler (for ex, say CS) so that it can act 
as well defined example for future plugin development. Hence asked you to 
suggest potential movable code parts from CS scheduler. Thoughts?

Also, Where shall we keep the plugin? RMActiveService? or Scheduler like 
[~leftnoteasy] suggested earlier? 

> Interface for adding extra behavior to node heartbeats
> ------------------------------------------------------
>
>                 Key: YARN-7018
>                 URL: https://issues.apache.org/jira/browse/YARN-7018
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: resourcemanager
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>            Priority: Major
>         Attachments: YARN-7018.POC.001.patch, YARN-7018.POC.002.patch, 
> YARN-7018.POC.003.patch
>
>
> This JIRA tracks an interface for plugging in new behavior to node heartbeat 
> processing.  Adding a formal interface for additional node heartbeat 
> processing would allow admins to configure new functionality that is 
> scheduler-independent without needing to replace the entire scheduler.  For 
> example, both YARN-5202 and YARN-5215 had approaches where node heartbeat 
> processing was extended to implement new functionality that was essentially 
> scheduler-independent and could be implemented as a plugin with this 
> interface.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to