[
https://issues.apache.org/jira/browse/YARN-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619572#comment-16619572
]
Bibin A Chundatt commented on YARN-7599:
----------------------------------------
Thank you [~botong] for clarification
Few comments on patch
# Can you change to single configuration similar to
{{dfs.http.client.retry.policy.spec}} {min,max,interval}. Advantage - reduces
configs
{code}
3381 public static final String GPG_APPCLEANER_MIN_ROUTER_SUCCESS =
3382 FEDERATION_GPG_PREFIX + "application.cleaner.min-router-success";
3389 public static final String GPG_APPCLEANER_MAX_ROUTER_RETRY =
3390 FEDERATION_GPG_PREFIX + "application.cleaner.max-router-retry";
3391 public static final int DEFAULT_GPG_APPCLEANER_MAX_ROUTER_RETRY = 10;
3397 public static final String GPG_APPCLEANER_ROUTER_RETRY_INTEVAL_MS =
3398 FEDERATION_GPG_PREFIX +
"application.cleaner.router-retry-interval-ms";
{code}
# Class should be DefaultApplicationCleaner
{code}
38 public class DefaultApplicationCleaner extends ApplicationCleaner {
39 private static final Logger LOG =
40 LoggerFactory.getLogger(ApplicationCleaner.class);
{code}
# Log flooding will happen in debug mode with current implementation. Comma
separated list is better
routerApps.stream().map(Object::toString).collect(Collectors.joining(","));
{code}
59 for (ApplicationId appId : routerApps) {
60 LOG.debug("Running application {} in the cluster",
appId.toString());
61 }
{code}
# Rename testcase name -> {{testBasicCase}}
Clarfication
# During long maintainance period of cluster, We might require option to
disable cleaner at run time. rt ??
> [GPG] ApplicationCleaner in Global Policy Generator
> ---------------------------------------------------
>
> Key: YARN-7599
> URL: https://issues.apache.org/jira/browse/YARN-7599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Botong Huang
> Assignee: Botong Huang
> Priority: Minor
> Labels: federation, gpg
> Attachments: YARN-7599-YARN-7402.v1.patch,
> YARN-7599-YARN-7402.v2.patch, YARN-7599-YARN-7402.v3.patch,
> YARN-7599-YARN-7402.v4.patch
>
>
> In Federation, we need a cleanup service for StateStore as well as Yarn
> Registry. For the former, we need to remove old application records. For the
> latter, failed and killed applications might leave records in the Yarn
> Registry (see YARN-6128). We plan to do both cleanup work in
> ApplicationCleaner in GPG
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
