[ 
https://issues.apache.org/jira/browse/YARN-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780637#comment-13780637
 ] 

shanyu zhao commented on YARN-1215:
-----------------------------------

+1
Looks good to me.
                
> Yarn URL should include userinfo
> --------------------------------
>
>                 Key: YARN-1215
>                 URL: https://issues.apache.org/jira/browse/YARN-1215
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 3.0.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>         Attachments: YARN-1215-trunk.2.patch, YARN-1215-trunk.patch
>
>
> In the {{org.apache.hadoop.yarn.api.records.URL}} class, we don't have an 
> userinfo as part of the URL. When converting a {{java.net.URI}} object into 
> the YARN URL object in {{ConverterUtils.getYarnUrlFromURI()}} method, we will 
> set uri host as the url host. If the uri has a userinfo part, the userinfo is 
> discarded. This will lead to information loss if the original uri has the 
> userinfo, e.g. foo://username:passw...@example.com will be converted to 
> foo://example.com and username/password information is lost during the 
> conversion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to