[
https://issues.apache.org/jira/browse/YARN-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628484#comment-16628484
]
Bibin A Chundatt edited comment on YARN-5939 at 9/26/18 9:44 AM:
-----------------------------------------------------------------
{quote}It firstly gets a FileSystem instance
{quote}
For multiple files, FileSystem instance can be the same rt ??. Incase of cache
enabled CACHEKEY of FileSystem is combination of schema+authority,not complete
uri. So DistributedFileSystem.close -> All the open streams will be closed of
that FileSystem instance.
Did i miss something?
*Code*
{code}
267 try (FileSystem sourceFs = sCopy.getFileSystem(conf)){
268 FileStatus sStat = sourceFs.getFileStatus(sCopy);
{code}
was (Author: bibinchundatt):
{quote}It firstly gets a FileSystem instance
{quote}
For multiple files, FileSystem instance can be the same rt ??. Incase of cache
enabled CACHEKEY of FileSystem is combination of schema+authority,not complete
uri. So DistributedFileSystem.close -> All the open streams will be closed of
that FileSystem instance.
Did i miss something??
> FSDownload leaks FileSystem resources
> -------------------------------------
>
> Key: YARN-5939
> URL: https://issues.apache.org/jira/browse/YARN-5939
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.5.1, 2.7.3
> Reporter: liuxiangwei
> Assignee: Weiwei Yang
> Priority: Major
> Labels: leak
> Attachments: YARN-5939.004.patch, YARN-5939.005.patch,
> YARN-5939.01.patch, YARN-5939.02.patch, YARN-5939.03.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Background
> To use our self-defined FileSystem class, the item of configuration
> "fs.%s.impl.disable.cache" should set to true.
> In YARN's source code, the class named
> "org.apache.hadoop.yarn.util.FSDownload" use getFileSystem but never close,
> which leading to file descriptor leak because our self-defined FileSystem
> class close the file descriptor when the close function is invoked.
> My Question below:
> 1. whether invoking "getFileSystem" but never close is YARN's expected
> behavior
> 2. what should we do in our self-defined FileSystem resolve it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
