[
https://issues.apache.org/jira/browse/YARN-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632209#comment-16632209
]
Vrushali C edited comment on YARN-8549 at 9/28/18 6:21 PM:
-----------------------------------------------------------
[~suma.shivaprasad]
Any particular reason you want would like null to be returned instead of a new
TimelineWriterResponse?
I think if we return null, it may result in a NPE instead of silently dropping
the data on the floor.
[~prabham]
One thing that I am wondering if it might be useful is that perhaps we should
add a debug log message saying that NoOP writer has enabled, hence dropping the
data? It may be hard to figure out the data loss if a particular machine has
this enabled but rest of the machines have the regular writer enabled. In that
case, partial data will be missing and the logs wont tell us that no-op writer
has been enabled. So perhaps in debug mode at least, we should log for writes
to timeline service that no op writer is enabled. Also for reader, else we
won't know why no data is being returned if one reader instance has this
enabled and other reader instances don't.
was (Author: vrushalic):
[~suma.shivaprasad]
Any particular reason you want would like null to be returned instead of a new
TimelineWriterResponse?
I think if we return null, it may result in a NPE instead of silently dropping
the data on the floor.
One thing that I am wondering if it might be useful is that perhaps we should
add a debug log message saying that NoOP writer has enabled, hence dropping the
data? It may be hard to figure out the data loss if a particular machine has
this enabled but rest of the machines have the regular writer enabled. In that
case, partial data will be missing and the logs wont tell us that no-op writer
has been enabled. So perhaps in debug mode at least, we should log for writes
to timeline service that no op writer is enabled. Also for reader, else we
won't know why no data is being returned if one reader instance has this
enabled and other reader instances don't.
> Adding a NoOp timeline writer and reader plugin classes for ATSv2
> -----------------------------------------------------------------
>
> Key: YARN-8549
> URL: https://issues.apache.org/jira/browse/YARN-8549
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2, timelineclient, timelineserver
> Reporter: Prabha Manepalli
> Assignee: Prabha Manepalli
> Priority: Minor
> Attachments: YARN-8549-branch-2.03.patch,
> YARN-8549-branch-2.04.patch, YARN-8549.v1.patch, YARN-8549.v2.patch,
> YARN-8549.v4.patch
>
>
> Stub implementation for TimeLineReader and TimeLineWriter classes.
> These are useful for functional testing of writer and reader path for ATSv2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
