[
https://issues.apache.org/jira/browse/YARN-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632765#comment-16632765
]
Sunil Govindan commented on YARN-8830:
--------------------------------------
Thanks [~bibinchundatt]
Few comments.
# Checkstyle issues are valid. Pls help to check.
# in below code,
{code:java}
1042 if (hostname != null ?
1043 !hostname.equals(that.hostname) :
1044 that.hostname != null)
1045 return false;{code}
I prefer something like this {{(hostname == null ? that.hostname == null :
hostname.equals(that.hostname))}}
This can avoid complete negation and be more simpler. And put a negation in
outer layer if the syntax to be kept. Else its tough to read. or you could send
return false as last statement and these if checks can return true. This is
only for readability.
> SLS tool not working in trunk
> -----------------------------
>
> Key: YARN-8830
> URL: https://issues.apache.org/jira/browse/YARN-8830
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-8830.001.patch
>
>
> Seems NodeDetails hashCode() and equals() causing too many node registration
> for large data set
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
