[
https://issues.apache.org/jira/browse/YARN-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634839#comment-16634839
]
Szilard Nemeth commented on YARN-8553:
--------------------------------------
Hi [~bsteinbach]!
Thanks for your comments.
1. Booleans have false values as a default, so I'm just relying on that fact.
Also removed the long initializers.
2. Good point, renamed the local variable.
3. I would keep those as well. The tests that provide normal values for the
setters are proving that the builder methods work well independently of the
other builder methods, thus acting as a safety-net for future changes.
> Reduce complexity of AHSWebService getApps method
> -------------------------------------------------
>
> Key: YARN-8553
> URL: https://issues.apache.org/jira/browse/YARN-8553
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Rohith Sharma K S
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-8553.001.patch, YARN-8553.001.patch,
> YARN-8553.002.patch, YARN-8553.003.patch
>
>
> YARN-8501 refactor the RMWebService#getApp. Similar refactoring required in
> AHSWebservice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
