[ 
https://issues.apache.org/jira/browse/YARN-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635493#comment-16635493
 ] 

Hudson commented on YARN-8785:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15094 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/15094/])
YARN-8785. Improve the error message when a bind mount is not (skumpf: rev 
5edb9d3b972ad51e23b9cac7928b38876068a463)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c


> Improve the error message when a bind mount is not whitelisted
> --------------------------------------------------------------
>
>                 Key: YARN-8785
>                 URL: https://issues.apache.org/jira/browse/YARN-8785
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 3.1.0, 2.9.1, 3.1.1, 3.1.2
>            Reporter: Simon Prewo
>            Assignee: Simon Prewo
>            Priority: Major
>              Labels: Docker
>             Fix For: 3.2.0, 3.1.2
>
>         Attachments: YARN-8785-branch-3.1.002.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> A user recieves the error message _Invalid docker rw mount_ when a container 
> tries to mount a directory which is not configured in property  
> *docker.allowed.rw-mounts*. 
> {code:java}
> Invalid docker rw mount 
> '/usr/local/hadoop/logs/userlogs/application_1536476159258_0004/container_1536476159258_0004_02_000001:/usr/local/hadoop/logs/userlogs/application_1536476159258_0004/container_1536476159258_0004_02_000001',
>  
> realpath=/usr/local/hadoop/logs/userlogs/application_1536476159258_0004/container_1536476159258_0004_02_000001{code}
> The error message makes the user think "It is not possible due to a docker 
> issue". My suggestion would be to put there a message like *Configuration of 
> the container executor does not allow mounting directory.*.
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c
> CURRENT:
> {code:java}
>     permitted_rw = check_mount_permitted((const char **) permitted_rw_mounts, 
> mount_src);
>     permitted_ro = check_mount_permitted((const char **) permitted_ro_mounts, 
> mount_src);
>     if (permitted_ro == -1 || permitted_rw == -1) {
>       fprintf(ERRORFILE, "Invalid docker mount '%s', realpath=%s\n", 
> values[i], mount_src);
> ...
> {code}
> NEW:
> {code:java}
>     permitted_rw = check_mount_permitted((const char **) permitted_rw_mounts, 
> mount_src);
>     permitted_ro = check_mount_permitted((const char **) permitted_ro_mounts, 
> mount_src);
>     if (permitted_ro == -1 || permitted_rw == -1) {
>       fprintf(ERRORFILE, "Configuration of the container executor does not 
> allow mounting directory '%s', realpath=%s\n", values[i], mount_src);
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to