[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635808#comment-16635808
]
Robert Kanter commented on YARN-8448:
-------------------------------------
Thanks for the review [~snemeth]. I was on PTO but am back now, so I was able
to address your comments:
- In {{ProxyCAManager}}, {{LOG}} and {{rmContext}} are currently unused, but
they will be in the sibling JIRA, YARN-8449, to add support for RM HA. When
splitting up the patch, it was simpler to leave these in for now. There's a
{{TODO}} in {{ProxyCAManager#recover}}.
- I don't think there's a benefit to making the "to" date in
{{createCACertAndKeyPair}} a {{static final}} variable. It's only ever used
once. By not making it {{static}}, we can let it be garbage collected.
- It is intentional that {{ProxyCA#createCACertAndKeyPair}} passes the same
string for the issuer and subject. This is because the CA is issuing a
certificate for itself, so it is both the subject (the one who the certificate
is for) and the issuer (the one issuing the certificate).
The 006 patch:
- Rebased on latest trunk
- Addressed comments from [~snemeth]
-- Added {{<bouncycastle.version>}} to pom
-- Removed unused imports
-- Deleted unused methods {{KeyStoreTestUtil#setAllowAllSSL}}
-- Fixed exit codes in {{container-executor.c#create_script_paths}}. I had
blindly copy-pasted some existing code, which also had the wrong exit code
(I've fixed that too).
-- Made {{TestApplicationMasterLauncher#testSetupTokens}} {{private}}
-- Removed unnecessary type argument in
{{TestApplicationMasterLauncher.MyAMLauncher#createAndSetAMRMToken}}
-- {{createTrustManager#checkClientTrusted}} no longer declares throwing a
{{CertificateException}}
> AM HTTPS Support
> ----------------
>
> Key: YARN-8448
> URL: https://issues.apache.org/jira/browse/YARN-8448
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Major
> Attachments: YARN-8448.001.patch, YARN-8448.002.patch,
> YARN-8448.003.patch, YARN-8448.004.patch, YARN-8448.005.patch,
> YARN-8448.006.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
