[
https://issues.apache.org/jira/browse/YARN-7644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637378#comment-16637378
]
Chandni Singh commented on YARN-7644:
-------------------------------------
Fixed some of the checkstyle warnings in patch 2.
The ones for indentation in ContainersLauncher follow the indentation of the
existing statements under case
{code:java}
/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainersLauncher.java:156:
ContainerLaunch existingLaunch = running.remove(containerId);: 'block'
child has incorrect indentation level 8, expected level should be 6.
[Indentation]
{code}
{quote}I think ContainerCleanup class belong to
org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task
instead of in
org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher for reusing
existing package structure.
{quote}
[~eyang] I think the
{{org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher}} is
better for ContainerCleanup. This package contains all the tasks- launch,
relaunch which are created by {{ContainersLauncher}} and are not used outside
this package.
> NM gets backed up deleting docker containers
> --------------------------------------------
>
> Key: YARN-7644
> URL: https://issues.apache.org/jira/browse/YARN-7644
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Eric Badger
> Assignee: Chandni Singh
> Priority: Major
> Labels: Docker
> Attachments: YARN-7644.001.patch, YARN-7644.002.patch
>
>
> We are sending a {{docker stop}} to the docker container with a timeout of 10
> seconds when we shut down a container. If the container does not stop after
> 10 seconds then we force kill it. However, the {{docker stop}} command is a
> blocking call. So in cases where lots of containers don't go down with the
> initial SIGTERM, we have to wait 10+ seconds for the {{docker stop}} to
> return. This ties up the ContainerLaunch handler and so these kill events
> back up. It also appears to be backing up new container launches as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
