[
https://issues.apache.org/jira/browse/YARN-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638786#comment-16638786
]
Haibo Chen commented on YARN-8750:
----------------------------------
Thansk [~snemeth] for the contribution. I have committed the patch to trunk,
addressing the line-longer-than-80 character issue. I notice inconsistent
indentation issues (2, 4 and 6 are used in mix)
> Refactor TestQueueMetrics
> -------------------------
>
> Key: YARN-8750
> URL: https://issues.apache.org/jira/browse/YARN-8750
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: YARN-8750.001.patch, YARN-8750.002.patch,
> YARN-8750.003.patch, YARN-8750.004.patch, YARN-8750.005.patch,
> YARN-8750.006.patch
>
>
> {{TestQueueMetrics#checkApps}} and {{TestQueueMetrics#checkResources}} have 8
> and 14 parameters, respectively.
> It is very hard to read the testcases that are using these methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
