[
https://issues.apache.org/jira/browse/YARN-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638902#comment-16638902
]
Szilard Nemeth commented on YARN-8644:
--------------------------------------
Hi [~haibochen]!
Referring to your previous comment, adding the new testcase
{{testFinalTransition}} was really unnecessary as its assertions were already
covered by another testcases.
I also removed {{verifyAppRemovedEvent}} and moved one assertion from it to
{{verifyAppRemovedSchedulerEvent}} that verifies whether the applicationEvent's
applicationId field corresponds to the actual application's id.
Also removed a lot of unnecessary changes: method visibility restrictions and
generic types from collections.
> Add more test coverage for RMAppImpl.FinalTransition
> ----------------------------------------------------
>
> Key: YARN-8644
> URL: https://issues.apache.org/jira/browse/YARN-8644
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-8644.001.patch, YARN-8644.002.patch,
> YARN-8644.003.patch, YARN-8644.004.patch, YARN-8644.005.patch,
> YARN-8644.006.patch, YARN-8644.007.patch, YARN-8644.008.patch,
> YARN-8644.009.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
