[
https://issues.apache.org/jira/browse/YARN-5742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639865#comment-16639865
]
Abhishek Modi commented on YARN-5742:
-------------------------------------
Thanks [~rohithsharma] for the patch. Overall it looks good to me. I am
assuming that after YARN-8834 goes in, we can refactor some of the code here.
Some minor comments:
# Should we get default max retries from the config. Or we can directly use
TimelineConnector to get the client.
# Line 133: Should we add a warn or error log.
# Line 660: Instead of sysout, we should log it.
# There are some minor checkstyle issues.
> Serve aggregated logs of historical apps from timeline service
> --------------------------------------------------------------
>
> Key: YARN-5742
> URL: https://issues.apache.org/jira/browse/YARN-5742
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Varun Saxena
> Assignee: Rohith Sharma K S
> Priority: Critical
> Attachments: YARN-5742-POC-v0.patch, YARN-5742.v0.patch
>
>
> ATSv1.5 daemon has servlet to serve aggregated logs. But enabling only ATSv2,
> does not serve logs from CLI and UI for completed application. Log serving
> story has completely broken in ATSv2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
