[ 
https://issues.apache.org/jira/browse/YARN-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640479#comment-16640479
 ] 

Haibo Chen commented on YARN-8659:
----------------------------------

Thanks [~snemeth] for the update! The new patch looks good to me overall. Two 
minor comments

1)  getAppsByApplicationIds() returns a map of appId to its json object. I 
think it suffices to just return the set of applciationIds collected, given we 
are not checking any other app information

2) 'rm.waitForState(app.getApplicationId(), RMAppState.FINISHED);' can be moved 
to  finishApp() method too.

The checkstyle issue can also be addressed.

> RMWebServices returns only RUNNING apps when filtered with queue
> ----------------------------------------------------------------
>
>                 Key: YARN-8659
>                 URL: https://issues.apache.org/jira/browse/YARN-8659
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 2.7.3
>            Reporter: Prabhu Joseph
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: Screen Shot 2018-08-13 at 8.01.29 PM.png, Screen Shot 
> 2018-08-13 at 8.01.52 PM.png, YARN-8659.001.patch, YARN-8659.002.patch
>
>
> RMWebServices returns only RUNNING apps when filtered with queue and returns 
> empty apps
> when filtered with both FINISHED states and queue.
> http://pjoseph-script-llap3.openstacklocal:8088/ws/v1/cluster/apps?queue=default
> http://pjoseph-script-llap3.openstacklocal:8088/ws/v1/cluster/apps?states=FINISHED&queue=default



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to