[
https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640491#comment-16640491
]
Haibo Chen commented on YARN-8842:
----------------------------------
Thanks [~snemeth] for the patch.
For a clean-code perspective, QueueMetricsForCustomResources can include memory
and cpu metrics too. Though I am not sure how that's going to impact the
compatibility (not sure if @Metric annotation is some sort of API) and
performance that [~wilfreds] is concerned with.
We can also split QueueMetricsForCustomResources into three instances, Pending,
Available and Allocated, so it is more readable.
I'll take another pass to look at the uni tests added later.
> Update QueueMetrics with custom resource values
> ------------------------------------------------
>
> Key: YARN-8842
> URL: https://issues.apache.org/jira/browse/YARN-8842
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-8842.001.patch, YARN-8842.002.patch,
> YARN-8842.003.patch
>
>
> This is the 2nd dependent jira of YARN-8059.
> As updating the metrics is an independent step from handling preemption, this
> jira only deals with the queue metrics update of custom resources.
> The following metrics should be updated:
> * allocated resources
> * available resources
> * pending resources
> * reserved resources
> * aggregate seconds preempted
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
