[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650587#comment-16650587
]
Haibo Chen commented on YARN-8448:
----------------------------------
Thanks [~rkanter] for addressing the comments!
{quote}The only reason we also verify (one of the) certs in the custom
{{HostnameVerifier}} is because we need to determine if we should ignore the
hostname of the certificate, or if we should fallback to the default one, which
does check the hostname; this was a convinent way to check if it's one of our
certs vs a real cert.
{quote}
Makes sense.
In addition to the checkstyle/license issue, one other minor thing from me
about the comment in YarnConfiguration and yarn-default.xml, "allow connections
to AMs that ..." is probably more accurate to say than "accept HTTP connections
though for AMs".
Otherwise, +1 from my side.
> AM HTTPS Support
> ----------------
>
> Key: YARN-8448
> URL: https://issues.apache.org/jira/browse/YARN-8448
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Major
> Attachments: YARN-8448.001.patch, YARN-8448.002.patch,
> YARN-8448.003.patch, YARN-8448.004.patch, YARN-8448.005.patch,
> YARN-8448.006.patch, YARN-8448.007.patch, YARN-8448.008.patch,
> YARN-8448.009.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
