[ 
https://issues.apache.org/jira/browse/YARN-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656932#comment-16656932
 ] 

Eric Badger commented on YARN-8916:
-----------------------------------

+1 lgtm (non-binding), pending hadoopqa

> Define a constant "docker" string in "ContainerRuntimeConstants.java" for 
> better maintainability
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8916
>                 URL: https://issues.apache.org/jira/browse/YARN-8916
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Zhankun Tang
>            Assignee: Zhankun Tang
>            Priority: Minor
>         Attachments: YARN-8916-trunk.001.patch
>
>
> There're several hard-code string "docker" exists. It's better to use a 
> constant string in "ContainerRuntimeConstants" to make this container type 
> easy to use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to