[
https://issues.apache.org/jira/browse/YARN-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661388#comment-16661388
]
Robert Kanter commented on YARN-8929:
-------------------------------------
Thanks for the patch [~haibochen]. Looks good overall; some trivial comments:
# I think we should rename {{CGroupsHandler#CGROUP_FILE_TASKS}} given that
we've changed it's value and it no longer makes sense
# {{DefaultOOMHandler#sigKill}}'s javadocs need to be updated to add {{@return}}
# Checkstyle + unit tests (if relevant)
> DefaultOOMHandler should only pick running containers to kill upon oom events
> -----------------------------------------------------------------------------
>
> Key: YARN-8929
> URL: https://issues.apache.org/jira/browse/YARN-8929
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.2.0
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Priority: Major
> Attachments: YARN-8929.00.patch
>
>
> DefaultOOMHandler currently currently sort all known containers based on the
> execution type primarily and their start time secondarily.
> However, it does not check if a container is running or not. Kill a
> non-running container will not release any memory, hence won't get us of the
> under-oom status.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
