[
https://issues.apache.org/jira/browse/YARN-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784404#comment-13784404
]
Bikas Saha commented on YARN-1141:
----------------------------------
+1 Looks good except for the following.
This test probably needs to be reversed right?
{code}
+ // Verify the blacklist can be updated independent of requesting containers
+ cs.allocate(appAttemptId, Collections.<ResourceRequest>emptyList(),
+ Collections.<ContainerId>emptyList(), null,
+ Collections.singletonList(host));
+ Assert.assertFalse(cs.getApplication(appAttemptId).isBlacklisted(host));
+ cs.allocate(appAttemptId, Collections.<ResourceRequest>emptyList(),
+ Collections.<ContainerId>emptyList(),
+ Collections.singletonList(host), null);
+ Assert.assertTrue(cs.getApplication(appAttemptId).isBlacklisted(host));
{code}
> Updating resource requests should be decoupled with updating blacklist
> ----------------------------------------------------------------------
>
> Key: YARN-1141
> URL: https://issues.apache.org/jira/browse/YARN-1141
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: YARN-1141.1.patch, YARN-1141.2.patch
>
>
> Currently, in CapacityScheduler and FifoScheduler, blacklist is updated
> together with resource requests, only when the incoming resource requests are
> not empty. Therefore, when the incoming resource requests are empty, the
> blacklist will not be updated even when blacklist additions and removals are
> not empty.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
