[ 
https://issues.apache.org/jira/browse/YARN-8927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666460#comment-16666460
 ] 

Eric Yang commented on YARN-8927:
---------------------------------

[~tangzhankun] Sorry for the confusion.  The "docker run" pull strategy is 
still being discussed in https://github.com/moby/moby/issues/13331 and 
https://github.com/moby/moby/issues/34394 .  My statement would be inaccurate 
for "docker run" out side of YARN.  Docker run without explicit pull will not 
update the image to latest.  In YARN, there is on going effort to move docker 
pull into localization phase.  If YARN-3854 is done, then it might have pull 
once and update to latest side effect.  The checking logic can be done in 
localization phase after YARN-3854.  I am concerned that YARN's separate effort 
might be a snow flake effect, if Docker decided to bring 13331 to closure.

> Better handling of "docker.trusted.registries" in container-executor's 
> "trusted_image_check" function
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8927
>                 URL: https://issues.apache.org/jira/browse/YARN-8927
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Zhankun Tang
>            Assignee: Zhankun Tang
>            Priority: Major
>
> There are some missing cases that we need to catch when handling 
> "docker.trusted.registries".
> The container-executor.cfg configuration is as follows:
> {code:java}
> docker.trusted.registries=tangzhankun,ubuntu,centos{code}
> It works if run DistrubutedShell with "tangzhankun/tensorflow"
> {code:java}
> "yarn ... -shell_env YARN_CONTAINER_RUNTIME_TYPE=docker -shell_env 
> YARN_CONTAINER_RUNTIME_DOCKER_IMAGE=tangzhankun/tensorflow
> {code}
> But run a DistrubutedShell job with "centos", "centos[:tagName]", "ubuntu" 
> and "ubuntu[:tagName]" fails:
> The error message is like:
> {code:java}
> "image: centos is not trusted"
> {code}
> We need better handling the above cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to